[WW-2064] XHTML checkbox template does not include tooltip consistently

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 2.0.8, 2.0.9
• Fix Version/s: 2.0.10, 2.1.0
• Component/s: Plugin - Tags
• Flags: Patch
• Assignee: James Holmes
• Reporter: Max Pimm
• Created: 26/Jul/07 14:09
• Updated: 28/Oct/12 22:13
• Resolved: 26/Jul/07 15:19

Description

In the freemarker template for the checkbox element in the xhtml template (templates/xhtml/checkbox.ftl) the way the tooltip element in generated is not consistent.

From what i can see in all other templates the tooltip is generated by including templats/xhtml/tooltip.ftl. In the check box template the tooltip is required three times (one for each of the different label positions). For the top position this is implemented via an include.

line37: <#include "/${parameters.templateDir}/xhtml/tooltip.ftl" />

However in the left and right positions it is implemented with inline code:

lines 69 and 79: <img src='<@s.url value="/struts/tooltip/tooltip.gif" includeParams="none" encode="false"/>' alt="${parameters.tooltip}" title="${parameters.tooltip}" onmouseover="return escape('${parameters.tooltip?js_string}');" />

I think that the lines 69 and 79 should use the same include as the line 37 so as to be able to profit from the dojo tooltip in the include and future changes to the tooltip include.