[WW-1541] PropertiesSettings does not close properties files properly

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.1
• Fix Version/s: 2.0.2
• Flags: Patch
• Assignee: David H. DeWolf
• Reporter: Rickard Öberg
• Created: 06/Dec/06 12:30
• Updated: 28/Oct/12 22:11
• Resolved: 06/Dec/06 12:52

Description

PropertiesSettings does not close the stream to the properties file that is read. This causes redeploy issues, since the properties file cannot be removed on undeploy. Fix the constructor code like this:
InputStream inStream = null;
try

{ inStream = settingsUrl.openStream(); settings.load(inStream); }

catch (IOException e)

{ throw new StrutsException("Could not load " + name + ".properties:" + e, e); }

finally
{
if (inStream != null)
try

{ inStream.close(); }

catch (IOException e)

{ // Ignore }

}