Uploaded image for project: 'Struts 2'
  1. Struts 2
  2. WW-1236

Missing test for null 'action' property in start() of URL component?

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • WW 2.2.1
    • WW 2.2.2
    • Plugin - Tags
    • None

    Description

      in the URL component, there's a check if the 'includeParameters' and 'value' properties are null, and if this is the case, it's treated as if 'includeParameters' is set to 'GET'. This causes incorrect behaviour when deploying the sample portlets in uPortal, since the 'action' property is used instead of the 'value' property. The test looks like this:

      if ((includeParams == null && value == null) || GET.equalsIgnoreCase(includeParams)) {

      Is a test for 'action' == null deliberately left out of this, or is it a bug?

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            nilsga Nils-Helge Garli
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment