[WSS-509] SecurityToken::isExpired: add clock skew option

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Won't Fix
• Affects Version/s: 1.6.16
• Fix Version/s: 1.6.17
• Component/s: WSS4J Core
• Assignee: Colm O hEigeartaigh
• Reporter: Willem Salembier
• Created: 28/Aug/14 09:32
• Updated: 28/Aug/14 10:15
• Resolved: 28/Aug/14 10:15

Description

We notice race conditions with some of our clients when CXF verifies if SecurityTokens cached locally are still valid or expired. One reason could be clock desynchronization, another reason is that while the token was still valid at the moment of request construction, it isn't when the SOAP message arrives on the server (1s difference suffices).

Is it possible to add a clock skew option to org.apache.cxf.ws.security.tokenstore.SecurityToken.isExpired() cfr whats been done in org.apache.ws.security.validate.SamlAssertionValidator.checkConditions(AssertionWrapper) with the futureTTL property. In SamlAssertionValidator the futureTTl is only used in the validFrom comparison, but in our case it should be considered also in the validTill comparison.

A possible workaround is to configure our STS to initialize Lifetime>Expires in the RSTR response to SAMLAssertion > Conditions > NotOnOrAfter - clock skew.