Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Not a Problem
    • Affects Version/s: None
    • Fix Version/s: 2.0.0
    • Component/s: None
    • Labels:
      None

      Description


      Is there really a need to have a separate Crypto instance to sign SAML Assertions? Maybe we should just use the signature Crypto instance for this instead?

        Activity

        Hide
        Marc Giger added a comment -

        Hi Colm,

        Do you mean the issuer crypto instance which is passed via SAMLCallback?:

        assertion.signAssertion(
        samlCallback.getIssuerKeyName(),
        samlCallback.getIssuerKeyPassword(),
        samlCallback.getIssuerCrypto(),
        samlCallback.isSendKeyValue()
        );

        My opinion is that we should leave it as it is for maximum flexibility and for "separation of concerns".
        But I don't really mind...

        Marc

        Show
        Marc Giger added a comment - Hi Colm, Do you mean the issuer crypto instance which is passed via SAMLCallback?: assertion.signAssertion( samlCallback.getIssuerKeyName(), samlCallback.getIssuerKeyPassword(), samlCallback.getIssuerCrypto(), samlCallback.isSendKeyValue() ); My opinion is that we should leave it as it is for maximum flexibility and for "separation of concerns". But I don't really mind... Marc
        Hide
        Colm O hEigeartaigh added a comment -

        Hi Marc,

        Yes that's what I meant. I don't really mind either The important thing is to make sure that the same approach is followed for both DOM & StAX.

        Colm.

        Show
        Colm O hEigeartaigh added a comment - Hi Marc, Yes that's what I meant. I don't really mind either The important thing is to make sure that the same approach is followed for both DOM & StAX. Colm.
        Hide
        Marc Giger added a comment -

        Hi Colm,

        Both implementation do behave the same way. Therefore will mark this issue as resolved.

        Marc

        Show
        Marc Giger added a comment - Hi Colm, Both implementation do behave the same way. Therefore will mark this issue as resolved. Marc

          People

          • Assignee:
            Marc Giger
            Reporter:
            Colm O hEigeartaigh
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development