Uploaded image for project: 'Wookie'
  1. Wookie
  2. WOOKIE-65

Refactored comet notifications with sibling-instance scope

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 0.9.1
    • Server
    • None

    Description

      I've created an refactored version of the Notifier helper that is less "scattergun" in its approach to propagating notifications to widget instances, using the DWR PageNormalizer interface.

      This does get rid of some code duplication and generally makes the notifier easier to extend.

      However, I haven't been able to really test this and see how it affects performance - while it generates fewer pushes to clients, each client request potentially triggers more activity, so its possible this could go either way.

      With that in mind I've attached a patch for review rather than committing these changes as I'd appreciate feedback before going ahead.

      Attachments

        1. notifications_patch.txt
          16 kB
          Scott Wilson
        2. notifications_patch_2.txt
          50 kB
          Scott Wilson

        Issue Links

          relates to

          New Feature - A new feature of the product, which has yet to be developed. WOOKIE-133 Implement inter-widget messaging

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            People

              Unassigned Unassigned
              scottbw Scott Wilson
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: