Uploaded image for project: 'Wink'
  1. Wink
  2. WINK-364

ApacheHttpClientConnectionHandler: openConnection should be synchronized, should be thread safe and support connection pooling

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.2
    • None
    • Client
    • Patch Available

    Description

      I found the following issues when using ApacheHttpClientConnectionHandler:
      a.) openConnection() should be synchronized. It need not be synchronized if the httpClient was passed in, but that is typically not the case
      b.) ApacheHttpClientConnectionHandler should be thread safe and support connection pooling
      c.) Deprecated method usage
      d.) Request not properly aborted when exceptions are thrown by httpClient#execute()

      I will attach a patch. Please review and apply the patch. Thanks

      Attachments

        Activity

          People

            Unassigned Unassigned
            pasam Seshu Pasam
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: