Wink
  1. Wink
  2. WINK-364

ApacheHttpClientConnectionHandler: openConnection should be synchronized, should be thread safe and support connection pooling

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.2
    • Fix Version/s: None
    • Component/s: Client
    • Labels:
    • Patch Info:
      Patch Available

      Description

      I found the following issues when using ApacheHttpClientConnectionHandler:
      a.) openConnection() should be synchronized. It need not be synchronized if the httpClient was passed in, but that is typically not the case
      b.) ApacheHttpClientConnectionHandler should be thread safe and support connection pooling
      c.) Deprecated method usage
      d.) Request not properly aborted when exceptions are thrown by httpClient#execute()

      I will attach a patch. Please review and apply the patch. Thanks

        Activity

        Hide
        Seshu Pasam added a comment -

        See bug description

        Show
        Seshu Pasam added a comment - See bug description
        Hide
        Seshu Pasam added a comment -

        Can someone review and apply the patch please?

        Who should I contact to get commit privileges? Thanks

        Show
        Seshu Pasam added a comment - Can someone review and apply the patch please? Who should I contact to get commit privileges? Thanks
        Hide
        Raymond Feng added a comment -

        Patch applied. Thank you!

        Show
        Raymond Feng added a comment - Patch applied. Thank you!
        Hide
        Hudson added a comment -

        Integrated in Wink-Trunk-JDK1.5 #475 (See https://builds.apache.org/job/Wink-Trunk-JDK1.5/475/)
        Apply the patch for https://issues.apache.org/jira/browse/WINK-364. Thanks, Seshu. (Revision 1307529)

        Result = SUCCESS
        rfeng : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1307529
        Files :

        • /incubator/wink/trunk/wink-client-apache-httpclient/src/main/java/org/apache/wink/client/ApacheHttpClientConfig.java
        • /incubator/wink/trunk/wink-client-apache-httpclient/src/main/java/org/apache/wink/client/internal/handlers/ApacheHttpClientConnectionHandler.java
        Show
        Hudson added a comment - Integrated in Wink-Trunk-JDK1.5 #475 (See https://builds.apache.org/job/Wink-Trunk-JDK1.5/475/ ) Apply the patch for https://issues.apache.org/jira/browse/WINK-364 . Thanks, Seshu. (Revision 1307529) Result = SUCCESS rfeng : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1307529 Files : /incubator/wink/trunk/wink-client-apache-httpclient/src/main/java/org/apache/wink/client/ApacheHttpClientConfig.java /incubator/wink/trunk/wink-client-apache-httpclient/src/main/java/org/apache/wink/client/internal/handlers/ApacheHttpClientConnectionHandler.java

          People

          • Assignee:
            Unassigned
            Reporter:
            Seshu Pasam
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development