[WINK-297] serviceability improvement; externalize strings, confirm formatting

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.1.2
• Fix Version/s: 1.1.2
• Component/s: Client, Common, Server
• Patch Info: Patch Available
• Assignee: Michael Rheinheimer
• Reporter: Michael Rheinheimer
• Created: 30/Jun/10 19:47
• Updated: 23/Jul/10 14:00
• Resolved: 06/Jul/10 15:38

Description

We've needed serviceability improvements for a while. Here's the first pass. I've externalized all strings that should be externalized, marked the rest with //$NON-NLS-#$ via Eclipse's tool, and here's the cool part: wrote a unittest to do the following:

1) checks that the strings that should be externalized are externalized (only debug messages do not need to be externalized)
2) checks that all keys referred to by Messages.getMessage actually exist
3) checks that there are no unused keys in the resource.properties file
4) checks that the number of params matches up with the number of braces {} in a formatted log string, both externalized and non-externalized

See attached patch. The test is under org.apache.wink.common.internal.i18n.MessagesTest.

I'll wait to commit this until the 1.1.1 release vote and process is done.