[WINK-175] Change ProvidersRegistry MediaTypeMap to allow gets to be faster

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0
• Fix Version/s: 1.0
• Component/s: Common
• Assignee: Bryant Luk
• Reporter: Bryant Luk
• Created: 09/Sep/09 17:10
• Updated: 13/Sep/09 22:50
• Resolved: 11/Sep/09 19:56

Description

Doug Larson did some more profiling and pointed out that on the ProvidersRegistry MediaTypeMap, using a ConcurrentHashMap over SimpleConcurrentMap actually improves performance by a few percentage points.

        private final SimpleMap<Class<?>, SoftReference<SimpleMap<MediaType, List<ObjectFactory<T>>>>> providersCache =
                                                                                                                          new SimpleConcurrentMap<Class<?>, SoftReference<SimpleMap<MediaType, List<ObjectFactory<T>>>>>(); ;

While the cache keys (Class<?>) would not be WeakReferences, the values would still be SoftReferences.

Thoughts?