[WICKET-7046] Avoid allocating StringResponse when no response filters are active

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 9.12.0
• Fix Version/s: 10.0.0-M1, 9.14.0
• Component/s: wicket-core
• Assignee: Thomas Heigl
• Reporter: Thomas Heigl
• Created: 16/Apr/23 13:50
• Updated: 19/Apr/23 14:35
• Resolved: 19/Apr/23 09:50

Description

AjaxRequestHandler#respond currently always allocates a new StringResponse:

final StringResponse bodyResponse = new StringResponse();
update.writeTo(bodyResponse, encoding);
CharSequence filteredResponse = invokeResponseFilters(bodyResponse);
response.write(filteredResponse);

Wrapping the response in a StringResponse is necessary for applying ResponseFilters that potentially modify the response.

The thing is this: By default, a Wicket application running in deployment mode, does not have any response filters active. So in that case, we can avoid all of this expensive buffering.

Issue Links

• links to: GitHub Pull Request #578