[WICKET-6927] Get rid of java.security.AccessController

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 9.5.0
• Fix Version/s: 10.0.0-M1, 9.6.0
• Component/s: wicket
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Martin Tzvetanov Grigorov
• Created: 20/Oct/21 07:44
• Updated: 06/Nov/21 08:11
• Resolved: 20/Oct/21 07:47

Description

Trying to build Wicket with JDK 17.0.1 fails with:

ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.3.1:jar (attach-javadocs) on project wicket-util: MavenReportException: Error while generating Javadoc: 
[ERROR] Exit code: 1 - /home/ubuntu/git/apache/wicket/wicket-util/src/main/java/org/apache/wicket/util/string/Strings.java:21: warning: [removal] AccessController in java.security has been deprecated and marked for removal
[ERROR] import java.security.AccessController;
[ERROR]                     ^
[ERROR] error: Error fetching URL: https://download.java.net/java/early_access/jdk17/docs/api/ (java.io.FileNotFoundException: https://download.java.net/java/early_access/jdk17/docs/api/package-list)
[ERROR] 1 error
[ERROR] 1 warning
[ERROR] 
 

 

Strings#LINE_SEPARATOR uses AccessController to read the system property "line.separator".

For Wicket 9.x we could use System.lineSeparator().

For Wicket 10.x we could drop #LINE_SEPARATOR because it is not used by Wicket itself. User applications could use System.lineSeparator().