Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-6825

wicket-ioc 9.0.0 throws IAE with JDK14, still includes outdated ASM 7.1.0 in cglib-nodep

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 9.1.0
    • None
    • None
    • Ubuntu 20.04, openjdk version "14.0.2" 2020-07-14

    Description

      Hi,

      We've been using JDK14 with Wicket 8.7.0 for a long time by hacking our pom.xml and excluding cglib-nodep (which contains org.ow2.asm:asm:7.1.0 just moved to a different namespace) from wicklet-ioc and overridding ASM with a more recent version like this:

       

      <dependency>
       <groupId>org.apache.wicket</groupId>
       <artifactId>wicket-ioc</artifactId>
       <exclusions>
         <exclusion>
           <groupId>cglib</groupId>
           <artifactId>cglib-nodep</artifactId>
         </exclusion>
       </exclusions>
      </dependency>
      
      <dependency>
       <groupId>org.ow2.asm</groupId>
       <artifactId>asm-util</artifactId>
       <version>7.3.1</version>
      </dependency>
      
      <dependency>
       <groupId>cglib</groupId>
       <artifactId>cglib</artifactId>
       <version>3.3.0</version>
      </dependency> 

      I see that Wicket 9.0.0 is still using cglib-nodep 3.3.0 and without the above hack, I get an "Unsupported class file major version 58" error when using the @SpringBean annotation on JDK14.

      Would you consider doing a Wicket 9.0.1 release that uses "cglib" instead of "cglib-nodep"  so that the 8.0.1 asm-utils dependency you already declared in the wicket-ioc POM can override the outdated ASM dependency declared by the "cglib" artifact ?

      [INFO] -------------------< org.apache.wicket:wicket-ioc >-------------------
       [INFO] Building Wicket IoC common code 9.1.0-SNAPSHOT
       [INFO] ------------------------------[ bundle ]------------------------------
       [INFO] 
       [INFO] — maven-dependency-plugin:3.1.1:tree (default-cli) @ wicket-ioc —
       [INFO] org.apache.wicket:wicket-ioc:bundle:9.1.0-SNAPSHOT
       [INFO] +- cglib:cglib-nodep:jar:3.3.0:compile
       [INFO] +- javax.inject:javax.inject:jar:1:compile
       [INFO] +- org.apache.wicket:wicket-core:jar:9.1.0-SNAPSHOT:compile
       [INFO] | +- com.github.openjson:openjson:jar:1.0.12:compile
       [INFO] | +- org.apache.wicket:wicket-request:jar:9.1.0-SNAPSHOT:compile
       [INFO] | +- org.apache.wicket:wicket-util:jar:9.1.0-SNAPSHOT:compile
       [INFO] | | +- commons-fileupload:commons-fileupload:jar:1.4:compile
       [INFO] | | +- commons-io:commons-io:jar:2.6:compile
       [INFO] | | +- org.apache.commons:commons-collections4:jar:4.4:compile
       [INFO] | | - org.junit.jupiter:junit-jupiter-engine:jar:5.6.2:test (optional) 
       [INFO] | | +- org.apiguardian:apiguardian-api:jar:1.1.0:test (optional) 
       [INFO] | | +- org.junit.platform:junit-platform-engine:jar:1.6.2:test (optional) 
       [INFO] | | | +- org.opentest4j:opentest4j:jar:1.2.0:test (optional) 
       [INFO] | | | - org.junit.platform:junit-platform-commons:jar:1.6.2:test (optional) 
       [INFO] | | - org.junit.jupiter:junit-jupiter-api:jar:5.6.2:test (optional) 
       [INFO] | - org.danekja:jdk-serializable-functional:jar:1.9.0:compile
       [INFO] +- org.objenesis:objenesis:jar:3.1:compile (optional) 
       [INFO] +- org.ow2.asm:asm-util:jar:8.0.1:compile
       [INFO] | +- org.ow2.asm:asm:jar:8.0.1:compile
       [INFO] | +- org.ow2.asm:asm-tree:jar:8.0.1:compile
       [INFO] | - org.ow2.asm:asm-analysis:jar:8.0.1:compile
       [INFO] +- org.mockito:mockito-core:jar:3.5.6:test
       [INFO] | +- net.bytebuddy:byte-buddy:jar:1.10.13:test
       [INFO] | - net.bytebuddy:byte-buddy-agent:jar:1.10.13:test
       [INFO] +- javax.servlet:javax.servlet-api:jar:3.1.0:provided
       [INFO] +- org.slf4j:slf4j-api:jar:1.7.25:compile
       [INFO] +- org.slf4j:jcl-over-slf4j:jar:1.7.25:test
       [INFO] - org.slf4j:slf4j-log4j12:jar:1.7.25:test
       [INFO] - log4j:log4j:jar:1.2.17:test (optional) 

       

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            mgrigorov Martin Tzvetanov Grigorov
            tgierke2342 Tobias Gierke
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment