[WICKET-6824] Use concatenation instead of String.format for frequently called methods

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 9.0.0
• Fix Version/s: 9.1.0, 8.10.0
• Component/s: wicket-core
• Assignee: Thomas Heigl
• Reporter: Thomas Heigl
• Created: 30/Aug/20 18:39
• Updated: 01/Oct/20 13:14
• Resolved: 01/Oct/20 13:14

Description

Two usages of String.format frequently show up in my production profiler:

Both methods are potentially called dozens or even hundreds of times for large pages.

String.format has horrible performance and should mostly be used for generating error messages and debug information. For a detailed analysis see: https://redfin.engineering/java-string-concatenation-which-way-is-best-8f590a7d22a8

We should replace String.format with simple concatenation in both instances.