Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-6759

Support disabling error notification for websockets

    XMLWordPrintableJSON

    Details

      Description

      Hi,

      WebSocketSettings currently supports disabling the broadcast of `close` events. This toggle has been added because notifications lead to deserialization of the page instance from the page store:

      	/**
      	 * A function that decides whether to notify the page/resource on
      	 * web socket connection closed event.
      	 * The page notification leads to deserialization of the page instance from
      	 * the page store and sometimes this is not wanted.
      	 */
      	private Function<Integer, Boolean> notifyOnCloseEvent = (code) -> true; 

      The same happens for `error` events, but it is not possible to disable the notification.

      Would it be possible to add another toggle `setNotifyOnErrorEvent`?

      I can provide a PR if necessary.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                mgrigorov Martin Tzvetanov Grigorov
                Reporter:
                thomas.heigl Thomas Heigl
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: