[WICKET-6759] Support disabling error notification for websockets

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 8.7.0
• Fix Version/s: 9.0.0-M5, 8.8.0
• Component/s: wicket-native-websocket
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Thomas Heigl
• Created: 18/Mar/20 12:06
• Updated: 20/Mar/20 12:53
• Resolved: 20/Mar/20 12:53

Description

Hi,

WebSocketSettings currently supports disabling the broadcast of `close` events. This toggle has been added because notifications lead to deserialization of the page instance from the page store:

	/**
	 * A function that decides whether to notify the page/resource on
	 * web socket connection closed event.
	 * The page notification leads to deserialization of the page instance from
	 * the page store and sometimes this is not wanted.
	 */
	private Function<Integer, Boolean> notifyOnCloseEvent = (code) -> true; 

The same happens for `error` events, but it is not possible to disable the notification.

Would it be possible to add another toggle `setNotifyOnErrorEvent`?

I can provide a PR if necessary.

Issue Links

• links to: GitHub Pull Request #416