[WICKET-6756] Avoid URL.getFile() when actually expecting paths.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 8.7.0
• Fix Version/s: 9.0.0-M5, 8.8.0
• Component/s: wicket-core
• Assignee: Sven Meier
• Reporter: Thorsten Schöning
• Created: 16/Mar/20 08:22
• Updated: 20/Mar/20 08:09
• Resolved: 19/Mar/20 20:06

Description

WICKET-6714 introduced using "URL.getFile" to convert some parts of an URL to a path in the local file system. This doesn't work properly, because the result of "getFile" is not properly decoded e.g. in case the URL/path contains spaces. While this concrete issue has been fixed by WICKET-6755 already, in theory this needs to be fixed i the entire code base as well. Each place URL.getFile is used to get some local file system path is wrong.

https://stackoverflow.com/questions/2166039/java-how-to-get-a-file-from-an-escaped-url

This is issue is created to make aware of that problem and because during WICKET-6755 I've found at least one additional place already where this problem happens.

Issue Links

• links to: GitHub Pull Request #414