Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-6720

ConcatBundleResource#getResourceStream should not eagerly fetch resources

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 8.5.0
    • 8.7.0, 9.0.0-M4
    • wicket-core
    • None

    Description

      If ConcatBundleResource is used in conjunction with LastModifiedResourceVersion, it will concatenate its resources for every request, even if unchanged.
      The reason for this is, that LastModifiedResourceVersion#getVersion uses only lastModified of the getResourceStream call to determine a version. But getResourceStream of ConcatBundleResource collects (and compresses) for that call already.

      This effectively cancels out any time saved by using the class in the first place.
      It should only collect and build the actual content "on demand".

      Attachments

        Activity

          People

            svenmeier Sven Meier
            denwal Dennis Waldherr
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: