[WICKET-6714] Please add better getResource-Support for MockServletContext

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 8.0.0, 9.0.0-M3
• Fix Version/s: 8.7.0, 9.0.0-M4
• Component/s: wicket-core
• Assignee: Sven Meier
• Reporter: Hans Schäfer
• Created: 27/Nov/19 10:56
• Updated: 16/Mar/20 08:56
• Resolved: 07/Dec/19 22:21

Description

Hello!

WicketTester does not provide a useful MockServletContext#getResource(). As WicketTester always instantiates MockServletContext passing a null-Value as path (webappRoot), the method MockServletContext#getResource always returns null, even if a resource in the classpath exists.
My proposal for the implementation of Method MockServletContext#getResource() is:
URL result = null;
if (name.startsWith("/")) {
   name = name.substring(1);
}

if (webappRoot != null) {
  final File f = new File(webappRoot, name);
  if (f.exists())

{      result = f.toURI().toURL(); }

if (result == null) {
   result = getClass().getClassLoader().getResource("META-INF/resources/" + name);
}
return result;

Best regards

Hans

Issue Links

• causes: WICKET-6755 MockServletContext does not decode real path
• links to: GitHub Pull Request #413

Sub-Tasks

• WebApplication.get().getServletContext().getRealPath("/") returning nonsense path: Open