[WICKET-6680] JavaScriptStripper chokes on template literals that contain two forward slashes

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 8.5.0, 9.0.0-M2, 7.14.0
• Fix Version/s: 8.6.1, 7.15.0, 9.0.0-M3
• Component/s: wicket-core
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Arthur Bogaart
• Created: 28/Jun/19 14:51
• Updated: 01/Jul/19 12:59
• Resolved: 01/Jul/19 12:30

Description

The DefaultJavaScriptCompressor uses the JavaScriptStripper to strip comments and whitespace from javascript code when running in production mode, but it has no support for / understanding of template literals. As such, it chokes on the following snippet

const url = `${protocol}//${hostname}:${port}`;

 as it identifies the two forward slashes as the beginning of a single-line comment, and removes the code after it, breaking the javascript.