Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-6673

PriorityHeaderItem ordering is wrong for siblings

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 9
    • Fix Version/s: 9.0.0-M3
    • Component/s: wicket
    • Labels:
      None

      Description

      PriorityHeaderItems allows parents to move their header items infront of those of their children (parent-first instead of child-first).

      But the current implemention sorts PriorityHeaderItems of siblings in reverse order, e.g. having a component hierarchy as follows:

      Component A
      +- Component AA
      +- Component AB
      

      ... the PriorityHeaderItems of all these components are sorted as:

      - PriorityHeaderItem of A
      - PriorityHeaderItem of AB
      - PriorityHeaderItem of AA
      

      Why should the PriorityHeaderItem of component AB be before that of AA? This isn't parent-first, it is reverse-order.

      IMHO a more suitable ordering would be "parent-first-preserving-siblings":

      - PriorityHeaderItem of A
      - PriorityHeaderItem of AA
      - PriorityHeaderItem of AB
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                svenmeier Sven Meier
                Reporter:
                svenmeier Sven Meier
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: