[WICKET-6637] Handling exception Wicket 8

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 8.3.0
• Fix Version/s: 9.0.0-M1, 8.4.0
• Component/s: wicket
• Labels: AjaxRequestTarget IRequestCycleListener onException
• Assignee: Sven Meier
• Reporter: Matus
• Created: 18/Feb/19 14:10
• Updated: 18/Feb/19 20:02
• Resolved: 18/Feb/19 20:02

Description

Hi,

 

recently we have upgraded our application, from wicket 7.11 to wicket 8.3.0.

With wicket 7 everything seemed to be fine, however in wicket 8 we have an issue

with handling exception.

In Application we have in init() method:

   getRequestCycleListeners().add(new MyRequestCycleListener()); 

MyRequestCycleListener implements IRequestCycleListener and override method

 

      @Override

  public IRequestHandler onException(RequestCycle cycle, Exception ex) {

  Optional<AjaxRequestTarget> target = cycle.find(AjaxRequestTarget.class);

  //this part stopped working since it return Optional.empty(), because active RequestHandler

  //and RequestHandlerScheduledAfterCurrent are both null

        if (target.isPresent()) {

            return target.get();

        }

        IPageRequestHandler last = PageRequestHandlerTracker.getLastHandler(RequestCycle.get());

        WebPage page = (WebPage) (last.getPage());

        return new RenderPageRequestHandler(new PageProvider(currentPage));

  }

Is this a wicket bug or it was intention to work like this? If it was intentended, is there

any workaround to get the AjaxRequestTarget? Or the approach has changed in wicket 8? Any other ideas?

We think, that this might be caused by https://issues.apache.org/jira/browse/WICKET-6129

Please see attached quisckstart, it worked fine with wicket 7.12

 

Issue Links

• is caused by: WICKET-6129 IRequestCycleListener not notified of all executed handlers