[WICKET-65] Handle String array in PageParameters

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.3.0-beta2
• Component/s: wicket
• Assignee: Alastair Maw
• Reporter: Jean-Baptiste Quenot
• Created: 14/Nov/06 14:08
• Updated: 01/Jun/07 10:13
• Resolved: 06/May/07 17:43

Description

When building PageParameters, it is possible to repeat
the same parameter name to build a string array, this
is documented here:

http://wicket.sourceforge.net/apidocs/wicket/util/value/ValueMap.html#add(java.lang.String,%20java.lang.String)

However when issuing setResponsePage(MyPage.class,
params) the newly constructed URL does not honour the
string array parameter, only the first value is used.

Example:

PageParameters params = new PageParameters();
params.add("a", "1");
params.add("a", "2");

This builds a parameter that is a String[] with name
"a" and values: ["1", "2"]. But the URL shown in the
browser is: http://server/app?a=1 instead of
http://server/app?a=1&a=2

Note that in the target page I'm using
params.getStringArray("a") to get the string array.

Please find attached a patch against branch wicket-1.x
that adresses the URL encoding issue. The patch also
refactors the URL encoding logic to have a more readable
and compact code.

Thanks in advance!

Issue Links

• relates to: WICKET-550 Use WebRequestEncoder everywhere a query string is constructed
• relates to: WICKET-539 QueryStringUrlCodingStrategy does not handle multi-valued parameters