[WICKET-6571] BaseWebSocketBehavior should check sessionId cookie name dynamically

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 8.0.0
• Fix Version/s: 8.1.0
• Component/s: wicket-native-websocket
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Jan Krakora
• Created: 24/Jul/18 14:26
• Updated: 19/Sep/18 10:15
• Resolved: 24/Jul/18 15:30

Description

When creating a WebSocket connection, Wicket tries to check if session id is tracked by URL or by cookies.

The code is in the org.apache.wicket.protocol.ws.api.BaseWebSocketBehavior#getSessionId(Component component)

It uses a hardcoded sessionId cookie name (JSESSIONID). So when an application uses a different sessionId cookie name, this code wrongly assumes there is no cookie with session id and appends session Id in the websocket connection URL.

I think it should use to get session id cookie name

servletContext.getSessionCookieConfig().getName()

 

Issue Links

• breaks: WICKET-6593 "A Cookie name can not be null or empty" when accessing page with WebSocketBehavior