Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-6290

CssUrlReplacer doesn't understand data: urls and breaks them

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 8.0.0-M2, 6.25.0, 7.5.0, 1.5.17
    • 7.6.0, 8.0.0-M3
    • None
    • None

    Description

      CssUrlReplacer tries to replace data: urls that are used to embed base64-encoded small images directly in CSS files. This leads to the following (from an adapted CssUrlReplacerTest I haven't pushed yet):

      Expected :.class {background-image: url(data:image/gif;base64,R0lGODlhEAAQAMQAAORHH);}
      Actual   :.class {background-image: url('./wicket/resource/org.apache.wicket.resource.CssUrlReplacerTest/res/css/data:image/gif;base64,R0lGODlhEAAQAMQAAORHH--decorated');}
      

      It should really just leave those URLs alone. I'll prepare a pull request.

      Attachments

        Activity

          People

            cmenzel Carl-Eric Menzel
            cmenzel Carl-Eric Menzel
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: