[WICKET-6271] IRequestableComponent getPage() javaDoc and Component implementation mismatch

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 6.25.0, 8.0.0
• Fix Version/s: 7.6.0, 8.0.0-M3
• Component/s: wicket
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Torsten Krah
• Created: 07/Nov/16 10:22
• Updated: 04/Jan/17 09:43
• Resolved: 08/Nov/16 12:02

Description

The

https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/request/component/IRequestableComponent.java

does tell in its javaDoc that getPage() may return null.

	/**
	 * Returns page this component belongs to.
	 * 
	 * @return page instance or <code>null</code>
	 */
IRequestablePage getPage();

Looking at the implementor

https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/Component.java

it does throw a WicketRuntimeException if it is null.
Looking at e.g. createRequestHandler(...) it does not check if its null either.

So are implementors allowed to return null here or is the javaDoc on the interface obsolete?