[WICKET-6242] Weak concurrency management in AuthenticatedWebSession#signedIn

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 8.0.0-M1, 7.4.0
• Fix Version/s: 8.0.0-M2, 7.5.0
• Component/s: wicket-auth-roles
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Martin Tzvetanov Grigorov
• Created: 10/Sep/16 11:10
• Updated: 19/Sep/16 19:45
• Resolved: 19/Sep/16 19:45

Description

Discussion at dev@: http://markmail.org/message/syo3m6hrf2ix55rz

Currently [1] uses a volatile boolean "signedIn" to control the state.
org.apache.wicket.authroles.authentication.panel.SignInPanel#onConfigure()
tries to make use of it.
IMO this implementation is a bit weak. There are big windows this state to
change in the meantime.

Usually this shouldn't be a big problem, the application will authenticate
the same user twice.
But if the application does something in ISessionListener#onBind() then it
becomes a problem [2].

1.
https://github.com/apache/wicket/blob/master/wicket-auth-roles/src/main/java/org/apache/wicket/authroles/authentication/AuthenticatedWebSession.java
2. https://issues.apache.org/jira/browse/ISIS-1481

Issue Links

• links to: GitHub Pull Request #180