Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-6228

Hide AuthenticatedWebSession#signOut() from the public API

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 7.4.0
    • Fix Version/s: 8.0.0-M2
    • Component/s: wicket-auth-roles
    • Labels:
      None

      Description

      Recently two Wicket users asked similar questions at StackOverflow what method to use for log out:

      IMO #signOut() should be made private or inlined in #invalidate() in Wicket 8.x.

      Opinions?

        Issue Links

          Activity

          Hide
          svenmeier Sven Meier added a comment -

          I'd vote for keeping #signOut() as an alias to #invalidate(), but I'm fine with removing it too.

          Show
          svenmeier Sven Meier added a comment - I'd vote for keeping #signOut() as an alias to #invalidate(), but I'm fine with removing it too.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 8c0c0b8004467906ab7d6c09ff72523da7755879 in wicket's branch refs/heads/master from Martin Grigorov
          [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=8c0c0b8 ]

          WICKET-6228 Hide AuthenticatedWebSession#signOut() from the public API

          Make AuthenticatedWebSession#signOut() an alias to #invalidate()

          Show
          jira-bot ASF subversion and git services added a comment - Commit 8c0c0b8004467906ab7d6c09ff72523da7755879 in wicket's branch refs/heads/master from Martin Grigorov [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=8c0c0b8 ] WICKET-6228 Hide AuthenticatedWebSession#signOut() from the public API Make AuthenticatedWebSession#signOut() an alias to #invalidate()
          Hide
          mgrigorov Martin Grigorov added a comment -

          Now #signOut() and an alias of #invalidate()

          Show
          mgrigorov Martin Grigorov added a comment - Now #signOut() and an alias of #invalidate()

            People

            • Assignee:
              mgrigorov Martin Grigorov
              Reporter:
              mgrigorov Martin Grigorov
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development