Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-6222

renderHead not called with anonymous inner Border class

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 8.0.0-M1, 7.4.0
    • 8.0.0-M2, 7.5.0
    • wicket
    • Patch

    Description

      Commit https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=8c43b38 introduced a bug that renderHead is not called on children if a Border is an nonymous inner class.

      line Border.java:679 the statement

      containerClass.equals(getClass())

      returns false when containerClass is an anonymous inner class.

      fix:

      If the line:

      boolean isBorderBodyTag = containerClass == null || containerClass.equals(getClass());

      is changed to:

      boolean isBorderBodyTag = containerClass == null || containerClass.isAssignableFrom(getClass());

      It works again, but I don't trust myself with this fix.

      Attachments

        Issue Links

          Activity

            People

              bitstorm Andrea Del Bene
              bhuism Bas Huisman
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: