Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-6203

Rename IModel#mapWith() to IModel#combineWith() and reorder the parameters

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Trivial
    • Resolution: Fixed
    • 8.0.0-M1
    • 8.0.0-M2
    • wicket

    Description

      The IModel#mapWith method actually combines two models using a BiFunction. Thus another name like 'combineWith' would be much more descriptive of the actual task.

      Furthermore providing the BiFunction to combine the two models as the first argument of 'mapWith'/'combineWith' might obscure the other Model used for longer lambda expressions, since it will be provided after the lambda expression. It might be better to provide the other Model as a first argument.

      Attachments

        Issue Links

          Activity

            People

              mgrigorov Martin Tzvetanov Grigorov
              noobymatze Matthias Metzger
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 10m
                  10m
                  Remaining:
                  Remaining Estimate - 10m
                  10m
                  Logged:
                  Time Spent - Not Specified
                  Not Specified