Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-6192

Remove recreateBookmarkablePagesAfterExpiry check in AbstractBookmarkableMapper#mapHandler

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 7.3.0
    • 8.0.0-M2, 7.5.0
    • None
    • None

    Description

      In a nutshell that's what we try to archive:
      Save a cookie on a client browser under the path of the current page.
      The page does have a mandatory named parameter!
      If the Session expires. The SessionExpiredPage will read the cookie and start a redirect.

      After resolving Ticket WICKET-6182:
      What happens now is that by the time the AbstractBookmarkableMapper wants to generate the URL of the component, before including the existent parameters,
      it does an getRecreateMountedPagesAfterExpiry() check (see here). which answers false and the existing parameters are not added to the new UrlInfo object.

      That in return will lead to a failure when calling setPlaceholders(copy, url) (see here) and results in a null url return value, that lets wicket default to the generic URL we had before.

      Attachments

        1. WICKET-6192.patch
          2 kB
          Martin Tzvetanov Grigorov
        2. wicket-sandbox.7z
          19 kB
          Ravi Knox

        Activity

          People

            mgrigorov Martin Tzvetanov Grigorov
            Ravi Knox Ravi Knox
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: