[WICKET-6178] MetaDataHeaderItem # generateString() should return specials characters escaped like StringEscapeUtils.escapeHtml(s) does

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 7.3.0, 6.23.0
• Fix Version/s: 8.0.0-M1, 7.4.0, 6.24.0
• Component/s: wicket
• External issue URL: http://apache-wicket.1842946.n4.nabble.com/MetaDataHeaderItem-generateString-td4674851.html
• Assignee: Andrea Del Bene
• Reporter: Francois
• Created: 08/Jun/16 10:55
• Updated: 17/Jun/16 16:34
• Resolved: 09/Jun/16 16:12

Description

I think MetaDataHeaderItem # generateString() should return specials characters escaped like
StringEscapeUtils.escapeHtml(s) does.

Apache Wicket 7.3.0 - MetaDataHeaderItem - Line 126 : append(JavaScriptUtils.escapeQuotes(value.toString()))
return qwerty'qwerty as qwerty\’qwerty

I would like the return to be qwerty'qwerty (for example for the metatag description).

Martin's answer :

Looking at
https://github.com/apache/wicket/blob/39fb20b112e2005dab8e17667e5a763b1d89f18e/wicket-core/src/main/java/org/apache/wicket/markup/head/MetaDataHeaderItem.java#L125-L127
I agree that only double quotes should be escaped because only double
quotes may end prematurely the value.