Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 8.0.0-M1, 7.4.0, 6.24.0
    • wicket
    • None

    Description

      The change in WICKET-5874 alters the behavior for getTagByWicketId but not getTagsByWicketId . Thus for markup like this:

      <div><img ...></div>

      getTagByWicketId will return the img tag, but getTagsByWicketId will return an empty list, which feels very inconsistent.

      Since HTML5 made the /> syntax optional for void elements like input and img, the XmlPullParser probably needs to be replaced with something that can parse HTML5. The fix in WICKET-5874 does not seem sufficient.

      Attachments

        Activity

          Commit 996e17c3c625411c14206c14cf6a6ac4e2296dc7 in wicket's branch refs/heads/wicket-6.x from Andrea Del Bene
          [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=996e17c ]

          WICKET-6173 WICKET-6172 makes TagTester.createTagsByAttribute stop
          working

          jira-bot ASF subversion and git services added a comment - Commit 996e17c3c625411c14206c14cf6a6ac4e2296dc7 in wicket's branch refs/heads/wicket-6.x from Andrea Del Bene [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=996e17c ] WICKET-6173 WICKET-6172 makes TagTester.createTagsByAttribute stop working

          Commit 86009a4436cf76b76a12e3c7f4dcb886c2041cf0 in wicket's branch refs/heads/WICKET-6183 from Andrea Del Bene
          [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=86009a4 ]

          WICKET-6173 WICKET-6172 makes TagTester.createTagsByAttribute stop
          working

          jira-bot ASF subversion and git services added a comment - Commit 86009a4436cf76b76a12e3c7f4dcb886c2041cf0 in wicket's branch refs/heads/ WICKET-6183 from Andrea Del Bene [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=86009a4 ] WICKET-6173 WICKET-6172 makes TagTester.createTagsByAttribute stop working

          Commit 7eced629a6b5ec6ee6be18da29efede1cc05714b in wicket's branch refs/heads/WICKET-6183 from Martin Tzvetanov Grigorov
          [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=7eced62 ]

          WICKET-6172 Inconsistent results from getTag[s]ByWicketId

          jira-bot ASF subversion and git services added a comment - Commit 7eced629a6b5ec6ee6be18da29efede1cc05714b in wicket's branch refs/heads/ WICKET-6183 from Martin Tzvetanov Grigorov [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=7eced62 ] WICKET-6172 Inconsistent results from getTag [s] ByWicketId

          Commit 8fe5a70d70c9a512fbfd35df9915ecea0237f548 in wicket's branch refs/heads/master from Andrea Del Bene
          [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=8fe5a70 ]

          WICKET-6173 WICKET-6172 makes TagTester.createTagsByAttribute stop
          working

          jira-bot ASF subversion and git services added a comment - Commit 8fe5a70d70c9a512fbfd35df9915ecea0237f548 in wicket's branch refs/heads/master from Andrea Del Bene [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=8fe5a70 ] WICKET-6173 WICKET-6172 makes TagTester.createTagsByAttribute stop working

          Commit 7febb298bc91b0619a162fb1271a69eff8aedf1a in wicket's branch refs/heads/wicket-7.x from Andrea Del Bene
          [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=7febb29 ]

          WICKET-6173 WICKET-6172 makes TagTester.createTagsByAttribute stop
          working

          jira-bot ASF subversion and git services added a comment - Commit 7febb298bc91b0619a162fb1271a69eff8aedf1a in wicket's branch refs/heads/wicket-7.x from Andrea Del Bene [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=7febb29 ] WICKET-6173 WICKET-6172 makes TagTester.createTagsByAttribute stop working

          Commit 447f887813fe3cd883d2e368c1ca976f18c4ccc4 in wicket's branch refs/heads/master from Martin Tzvetanov Grigorov
          [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=447f887 ]

          WICKET-6172 Inconsistent results from getTag[s]ByWicketId

          jira-bot ASF subversion and git services added a comment - Commit 447f887813fe3cd883d2e368c1ca976f18c4ccc4 in wicket's branch refs/heads/master from Martin Tzvetanov Grigorov [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=447f887 ] WICKET-6172 Inconsistent results from getTag [s] ByWicketId

          Thanks!

          mgrigorov Martin Tzvetanov Grigorov added a comment - Thanks!

          Commit 0b4907fe660d6e706b14255882bf947f264f3a8c in wicket's branch refs/heads/wicket-6.x from Martin Tzvetanov Grigorov
          [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=0b4907f ]

          WICKET-6172 Inconsistent results from getTag[s]ByWicketId

          jira-bot ASF subversion and git services added a comment - Commit 0b4907fe660d6e706b14255882bf947f264f3a8c in wicket's branch refs/heads/wicket-6.x from Martin Tzvetanov Grigorov [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=0b4907f ] WICKET-6172 Inconsistent results from getTag [s] ByWicketId

          Commit 2ef6f14ed4a57567d6dc6b3131254ff8884fecab in wicket's branch refs/heads/wicket-7.x from Martin Tzvetanov Grigorov
          [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=2ef6f14 ]

          WICKET-6172 Inconsistent results from getTag[s]ByWicketId

          jira-bot ASF subversion and git services added a comment - Commit 2ef6f14ed4a57567d6dc6b3131254ff8884fecab in wicket's branch refs/heads/wicket-7.x from Martin Tzvetanov Grigorov [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=2ef6f14 ] WICKET-6172 Inconsistent results from getTag [s] ByWicketId

          Quickstart showing the issue.
          Both "logo" tests should pass, but only one does.

          boris@alum.mit.edu Boris Goldowsky added a comment - Quickstart showing the issue. Both "logo" tests should pass, but only one does.

          Please provide a test case.

          mgrigorov Martin Tzvetanov Grigorov added a comment - Please provide a test case.

          People

            mgrigorov Martin Tzvetanov Grigorov
            boris@alum.mit.edu Boris Goldowsky
            Votes:
            0 Vote for this issue
            Watchers:
            Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack