[WICKET-6107] Broadcast onClose event regardless of the JSR 356 WebSocket connection closed state

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 7.2.0
• Fix Version/s: 7.3.0, 8.0.0-M1
• Component/s: wicket-native-websocket
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Jan Krakora
• Created: 26/Feb/16 18:32
• Updated: 21/May/16 14:44
• Resolved: 27/Feb/16 00:04

Description

When is a WebSocket connection closed, the org.apache.wicket.protocol.ws.javax.WicketEndpoint.onClose() is called. This will in turn broadcast an event message to a page that is bound to that connection. The problem is when the connection is set to the closed state before calling this method - then the event is not broadcasted. See org.apache.wicket.protocol.ws.api.AbstractWebSocketProcessor.broadcastMessage() where is checked if the connection is open.

If a client (developer) of the wicket's WebSocket API need to know when a connection is closed, there is no chance in the scenario above.

I would suggest to let the AbstractWebSocketProcessor broadcast the ClosedMessage even if the connection is closed.

Issue Links

• breaks: WICKET-6167 Random ConcurrentModificationException since upgrade to 7.3.0