Details

    • Type: Task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 8.0.0-M1
    • Fix Version/s: 8.0.0-M8
    • Component/s: wicket, wicket-datetime
    • Labels:
      None

      Description

      Discussion at dev@: http://markmail.org/message/uqu6gfma6wihwcwt

      The idea is to:

      • preserve DateConverter classes in wicket-util (and use Java 8 java.time.** classes instead of Joda-Time).
      • move DateLabel to wicket-extensions
      • synch -datetime's DateTextField with -extensions' DateTextField
      • move everything else in WicketStuff project so existing applications could easily migrate to Wicket 8

      there are many topics to improve on:

      • DateConverter should be name DateTimeConverter and convert to LocalDateTime
      • DateField should work on a LocalDate (no longer extending DateTimeField)
      • without the DatePicker we could merge DateField and DateTextField
      • TimeField should work on a LocalTime (no longer extending DateTimeField)
      • for DateTimeField we should consider whether it works on ZonedDateTime or LocalDateTime - AFAIK most people use the former

        Issue Links

          Activity

          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 6083c8157845681df8a430e33598a545b0da7c35 in wicket's branch refs/heads/WICKET-6105-java.time from Martin Grigorov
          [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=6083c81 ]

          WICKET-6105 Decommission wicket-datetime

          Remove Maven site files

          Show
          jira-bot ASF subversion and git services added a comment - Commit 6083c8157845681df8a430e33598a545b0da7c35 in wicket's branch refs/heads/ WICKET-6105 -java.time from Martin Grigorov [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=6083c81 ] WICKET-6105 Decommission wicket-datetime Remove Maven site files
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 4da2ef043aac1f681233c04d2228fca50d6e900a in wicket's branch refs/heads/WICKET-6105-java.time from Martin Grigorov
          [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=4da2ef0 ]

          WICKET-6105 Decommission wicket-datetime

          Move DateLabel and all Date formatters from wicket-datetime to wicket-extensions module
          WIP!

          Show
          jira-bot ASF subversion and git services added a comment - Commit 4da2ef043aac1f681233c04d2228fca50d6e900a in wicket's branch refs/heads/ WICKET-6105 -java.time from Martin Grigorov [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=4da2ef0 ] WICKET-6105 Decommission wicket-datetime Move DateLabel and all Date formatters from wicket-datetime to wicket-extensions module WIP!
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 6083c8157845681df8a430e33598a545b0da7c35 in wicket's branch refs/heads/master from Martin Grigorov
          [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=6083c81 ]

          WICKET-6105 Decommission wicket-datetime

          Remove Maven site files

          Show
          jira-bot ASF subversion and git services added a comment - Commit 6083c8157845681df8a430e33598a545b0da7c35 in wicket's branch refs/heads/master from Martin Grigorov [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=6083c81 ] WICKET-6105 Decommission wicket-datetime Remove Maven site files
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 63f0c62796097f7228c36bde0c79fab980bf2ae6 in wicket's branch refs/heads/pr-160-master from Martin Grigorov
          [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=63f0c62 ]

          WICKET-6105 Decommission wicket-datetime

          Remove Maven site files

          Show
          jira-bot ASF subversion and git services added a comment - Commit 63f0c62796097f7228c36bde0c79fab980bf2ae6 in wicket's branch refs/heads/pr-160-master from Martin Grigorov [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=63f0c62 ] WICKET-6105 Decommission wicket-datetime Remove Maven site files
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1b99716338c149a6701b78cfa1acc25cfa6dd721 in wicket's branch refs/heads/WICKET-6105-java.time from Martin Grigorov
          [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=1b99716 ]

          WICKET-6105 Decommission Wicket-Datetime module

          WIP: Move some more code from -datetime to -extensions while trying to keep old APIs (j.u.Date based ones) available for easier migration

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1b99716338c149a6701b78cfa1acc25cfa6dd721 in wicket's branch refs/heads/ WICKET-6105 -java.time from Martin Grigorov [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=1b99716 ] WICKET-6105 Decommission Wicket-Datetime module WIP: Move some more code from -datetime to -extensions while trying to keep old APIs (j.u.Date based ones) available for easier migration
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit b82bce9cd9ee8ee203801d50c9916dd5570ac3f1 in wicket's branch refs/heads/WICKET-6105-java.time from Martin Grigorov
          [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=b82bce9 ]

          WICKET-6105 Decommission Wicket-Datetime module

          WIP: Bug fixes and API improvements

          Show
          jira-bot ASF subversion and git services added a comment - Commit b82bce9cd9ee8ee203801d50c9916dd5570ac3f1 in wicket's branch refs/heads/ WICKET-6105 -java.time from Martin Grigorov [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=b82bce9 ] WICKET-6105 Decommission Wicket-Datetime module WIP: Bug fixes and API improvements
          Hide
          bitstorm Andrea Del Bene added a comment -

          Hi Martin,

          is this completed ?

          Show
          bitstorm Andrea Del Bene added a comment - Hi Martin, is this completed ?
          Hide
          mgrigorov Martin Grigorov added a comment -

          No, not really.
          It is halfway done.
          But I don't have much spare time lately and bug reports have higher priority than this for me.
          If someone else finds this as interesting task then please take it over!

          Show
          mgrigorov Martin Grigorov added a comment - No, not really. It is halfway done. But I don't have much spare time lately and bug reports have higher priority than this for me. If someone else finds this as interesting task then please take it over!
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 8019324c27739a705205e1c499f4509c0dc3c194 in wicket's branch refs/heads/WICKET-6105-java.time from Maxim Solodovnik
          [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=8019324 ]

          Merge remote-tracking branch 'origin/master' into WICKET-6105-java.time

          Show
          jira-bot ASF subversion and git services added a comment - Commit 8019324c27739a705205e1c499f4509c0dc3c194 in wicket's branch refs/heads/ WICKET-6105 -java.time from Maxim Solodovnik [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=8019324 ] Merge remote-tracking branch 'origin/master' into WICKET-6105 -java.time
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit a9b06ca2e23a76dd99c3e77f3fc4e9aa17a2f815 in wicket's branch refs/heads/WICKET-6105-java.time from Maxim Solodovnik
          [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=a9b06ca ]

          Merge branch 'master' into WICKET-6105-java.time

          Show
          jira-bot ASF subversion and git services added a comment - Commit a9b06ca2e23a76dd99c3e77f3fc4e9aa17a2f815 in wicket's branch refs/heads/ WICKET-6105 -java.time from Maxim Solodovnik [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=a9b06ca ] Merge branch 'master' into WICKET-6105 -java.time
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 9051b43fb21243597809413c6387af896508db54 in wicket's branch refs/heads/WICKET-6105-java.time from Maxim Solodovnik
          [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=9051b43 ]

          Merge branch 'master' into WICKET-6105-java.time

          Show
          jira-bot ASF subversion and git services added a comment - Commit 9051b43fb21243597809413c6387af896508db54 in wicket's branch refs/heads/ WICKET-6105 -java.time from Maxim Solodovnik [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=9051b43 ] Merge branch 'master' into WICKET-6105 -java.time
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 66f8f2aeca8ec19df43a11bd6114d6fe006cbc31 in wicket's branch refs/heads/WICKET-6105-java.time from Maxim Solodovnik
          [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=66f8f2a ]

          Merge remote-tracking branch 'origin/master' into WICKET-6105-java.time

          Show
          jira-bot ASF subversion and git services added a comment - Commit 66f8f2aeca8ec19df43a11bd6114d6fe006cbc31 in wicket's branch refs/heads/ WICKET-6105 -java.time from Maxim Solodovnik [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=66f8f2a ] Merge remote-tracking branch 'origin/master' into WICKET-6105 -java.time
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit e688440166442a05675683669d688c025fa083fa in wicket's branch refs/heads/WICKET-6105-java.time from Sven Meier
          [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=e688440 ]

          WICKET-6105 corrected link to example

          Show
          jira-bot ASF subversion and git services added a comment - Commit e688440166442a05675683669d688c025fa083fa in wicket's branch refs/heads/ WICKET-6105 -java.time from Sven Meier [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=e688440 ] WICKET-6105 corrected link to example
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 39bbfb91cd5d44c9dcf0e5cfda9d62a1e948acd6 in wicket's branch refs/heads/WICKET-6105-java.time from Maxim Solodovnik
          [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=39bbfb9 ]

          Merge remote-tracking branch 'origin/master' into WICKET-6105-java.time

          Show
          jira-bot ASF subversion and git services added a comment - Commit 39bbfb91cd5d44c9dcf0e5cfda9d62a1e948acd6 in wicket's branch refs/heads/ WICKET-6105 -java.time from Maxim Solodovnik [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=39bbfb9 ] Merge remote-tracking branch 'origin/master' into WICKET-6105 -java.time
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit c9904a492172b7811fa8aad540a10d0f3b0e0dd8 in wicket's branch refs/heads/WICKET-6105-java.time from Sven Meier
          [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=c9904a4 ]

          WICKET-6105 split tests

          Show
          jira-bot ASF subversion and git services added a comment - Commit c9904a492172b7811fa8aad540a10d0f3b0e0dd8 in wicket's branch refs/heads/ WICKET-6105 -java.time from Sven Meier [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=c9904a4 ] WICKET-6105 split tests
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 5f978f1888354e159031544b936aec3e2785aaf5 in wicket's branch refs/heads/WICKET-6105-java.time from Maxim Solodovnik
          [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=5f978f1 ]

          WICKET-6105 serialVersionUID are added and whitespaces are fixed

          Show
          jira-bot ASF subversion and git services added a comment - Commit 5f978f1888354e159031544b936aec3e2785aaf5 in wicket's branch refs/heads/ WICKET-6105 -java.time from Maxim Solodovnik [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=5f978f1 ] WICKET-6105 serialVersionUID are added and whitespaces are fixed
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 2bb684c11a1d8b91db5c3d3040da734ed357a2bc in wicket's branch refs/heads/master from Martin Grigorov
          [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=2bb684c ]

          WICKET-6105 Decommission wicket-datetime

          Move DateLabel and all Date formatters from wicket-datetime to wicket-extensions module
          WIP!

          WIP: Move some more code from -datetime to -extensions while trying to keep old APIs (j.u.Date based ones) available for easier migration

          Show
          jira-bot ASF subversion and git services added a comment - Commit 2bb684c11a1d8b91db5c3d3040da734ed357a2bc in wicket's branch refs/heads/master from Martin Grigorov [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=2bb684c ] WICKET-6105 Decommission wicket-datetime Move DateLabel and all Date formatters from wicket-datetime to wicket-extensions module WIP! WIP: Move some more code from -datetime to -extensions while trying to keep old APIs (j.u.Date based ones) available for easier migration
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 2f6b59effd25a92385417e65724d835c8fdc0459 in wicket's branch refs/heads/master from Maxim Solodovnik
          [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=2f6b59e ]

          WICKET-6105 More tests are added some issues are fixed

          Show
          jira-bot ASF subversion and git services added a comment - Commit 2f6b59effd25a92385417e65724d835c8fdc0459 in wicket's branch refs/heads/master from Maxim Solodovnik [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=2f6b59e ] WICKET-6105 More tests are added some issues are fixed
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 0a4b5f2eb0ae047c127a2d07f084d299d59eabc1 in wicket's branch refs/heads/master from Sven Meier
          [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=0a4b5f2 ]

          WICKET-6105 restructured, fixed javadoc

          Show
          jira-bot ASF subversion and git services added a comment - Commit 0a4b5f2eb0ae047c127a2d07f084d299d59eabc1 in wicket's branch refs/heads/master from Sven Meier [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=0a4b5f2 ] WICKET-6105 restructured, fixed javadoc
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit a4aed9e35a6055d627960a58eee40e29d84c461d in wicket's branch refs/heads/master from Sven Meier
          [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=a4aed9e ]

          WICKET-6105 split tests

          Show
          jira-bot ASF subversion and git services added a comment - Commit a4aed9e35a6055d627960a58eee40e29d84c461d in wicket's branch refs/heads/master from Sven Meier [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=a4aed9e ] WICKET-6105 split tests
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1176c0a6d7051f51d72eafdd648602c9fad6669a in wicket's branch refs/heads/master from Maxim Solodovnik
          [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=1176c0a ]

          WICKET-6105 serialVersionUID are added and whitespaces are fixed

          This closes #235

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1176c0a6d7051f51d72eafdd648602c9fad6669a in wicket's branch refs/heads/master from Maxim Solodovnik [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=1176c0a ] WICKET-6105 serialVersionUID are added and whitespaces are fixed This closes #235
          Hide
          eximius Kamil added a comment -

          shouldn't this be resolved?

          Show
          eximius Kamil added a comment - shouldn't this be resolved?
          Hide
          solomax Maxim Solodovnik added a comment -

          Done, thanks

          Show
          solomax Maxim Solodovnik added a comment - Done, thanks

            People

            • Assignee:
              solomax Maxim Solodovnik
              Reporter:
              mgrigorov Martin Grigorov
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development