[WICKET-6006] ModalWindow.closeCurrent() causes 414 status error

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 6.20.0, 7.0.0
• Fix Version/s: 7.2.0, 8.0.0-M1, 6.22.0
• Component/s: wicket-extensions
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Martijn Dashorst
• Created: 16/Oct/15 15:41
• Updated: 24/Dec/15 13:18
• Resolved: 12/Dec/15 22:12

Description

When you have a panel inside a modal window, and the panel contains a form with e.g. a textarea, and you fill the textarea with about 10k of text, when the modal window is closed using closeCurrent() you get a 414 status error stating that the URL is too long (depends on the backend server).

	public ModalPanel1(String id)
	{
		super(id);

		Form<?> form = new Form<>("form");
		add(form);

		add(new AjaxLink<Void>("closeCancel") {
			@Override
			public void onClick(AjaxRequestTarget target) {
				ModalWindow.closeCurrent(target);
			}
		});

		StringBuilder sb = new StringBuilder();
		for (int i = 0; i < 10000; i++)
			sb.append("a");
		form.add(new TextArea<>("bigFingTextField", Model.of(sb.toString())));
	}

Closing the window using ModalWindow.closeCurrent() will add the serializedForm of the modal window's contents (See line 656 of wicket-ajax-debug.js) to the URL that's sent to wicket. If the form inside the panel contains lots of data, this will exceed the maximum URL length...

https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js#L656

The workaround is of course to use ModalWindow#close(IPartialPageRequestHandler) instead, however, why is ModalWindow#closeCurrent() even there, and why doesn't it properly close the window with the same behavior as the instance method?

Issue Links

• is broken by: WICKET-5948 wicket-ajax.js probably doesn't traverse the children of <div> or <span>
• is related to: WICKET-6050 Wicket Ajax (Wicket.From.serializeElement) causes 400 bad request