Wicket
  1. Wicket
  2. WICKET-593

equals() in ResourceStreamRequestTarget compares the wrong filename

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.2.6
    • Fix Version/s: 1.2.7, 1.3.0-beta2
    • Component/s: wicket
    • Labels:
      None

      Description

      In ResourceStreamRequestTarget, the equals() method is:

      public boolean equals(Object obj)
      {
      if (obj instanceof ResourceStreamRequestTarget)

      { ResourceStreamRequestTarget that = (ResourceStreamRequestTarget)obj; return resourceStream.equals(that.resourceStream) && ((fileName != null) ? fileName.equals(this.fileName) : true); }

      return false;
      }

      Note that the fileName is comparing to itself. It should really be:

      fileName.equals(that.fileName)

        Activity

        Kent Tong created issue -
        Johan Compagner made changes -
        Field Original Value New Value
        Status Open [ 1 ] Closed [ 6 ]
        Fix Version/s 1.3.0-beta2 [ 12312502 ]
        Resolution Fixed [ 1 ]
        Fix Version/s 1.2.7 [ 12312468 ]
        Assignee Johan Compagner [ jcompagner ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Closed Closed
        8h 15m 1 Johan Compagner 27/May/07 11:50

          People

          • Assignee:
            Johan Compagner
            Reporter:
            Kent Tong
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development