[WICKET-593] equals() in ResourceStreamRequestTarget compares the wrong filename

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 1.2.6
• Fix Version/s: 1.2.7, 1.3.0-beta2
• Component/s: wicket
• Assignee: Johan Compagner
• Reporter: Kent Tong
• Created: 27/May/07 02:35
• Updated: 27/May/07 10:50
• Resolved: 27/May/07 10:50

Description

In ResourceStreamRequestTarget, the equals() method is:

public boolean equals(Object obj)
{
if (obj instanceof ResourceStreamRequestTarget)

{ ResourceStreamRequestTarget that = (ResourceStreamRequestTarget)obj; return resourceStream.equals(that.resourceStream) && ((fileName != null) ? fileName.equals(this.fileName) : true); }

return false;
}

Note that the fileName is comparing to itself. It should really be:

fileName.equals(that.fileName)