Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-5732

Improve component queuing and auto component

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Critical
    • Resolution: Implemented
    • Affects Version/s: 7.0.0-M3
    • Fix Version/s: 7.0.0-M5
    • Component/s: None
    • Labels:
      None

      Description

      One of the new feature implemented in Wicket 7 is component queuing (see https://www.42lines.net/2014/02/28/component-queueing-in-wicket-7).
      Amongst other things, component queuing is aimed to improve auto components usage.
      The current implementation of component queuing has raised some issues (WICKET-5730, WICKET-5724) which might make impossible for a Wicket application to migrate from 6.x to 7.x.
      As a consequence I've tried to find a solution that could solved the encountered issues without changing the expected behavior for component queuing. The solution can be seen in the new branch 'improvingQueuing' (https://github.com/apache/wicket/tree/improvingQueuing).

      However, this solution comes at the price of changing the current way Wicket handles auto component. So far Wicket removes auto components added during rendering phase after this latter has finished. On the contrary, my solution implies that auto components must stay in their hierarchy
      This is of course quite a big change to Wicket internals, so ad Martin Grigorov suggested, we should discuss it before merging it to master branch.

        Activity

        Hide
        bitstorm Andrea Del Bene added a comment -

        Reading back Igor Vaynberg blog post, I've found the following statement:
        "As part of Queueing implementation Wicket will properly insert auto components into the Java hierarchy. Furthermore, auto components will remain in the hierarchy instead of being added before render and removed afterwords. "

        Show
        bitstorm Andrea Del Bene added a comment - Reading back Igor Vaynberg blog post, I've found the following statement: "As part of Queueing implementation Wicket will properly insert auto components into the Java hierarchy. Furthermore, auto components will remain in the hierarchy instead of being added before render and removed afterwords. "
        Hide
        mgrigorov Martin Grigorov added a comment -

        In Igor's initial work the dequeued components are added as normal components, i.e. using add() (see org.apache.wicket.MarkupContainer#addDequeuedComponent). So they are not auto components.

        Auto components are those added to the hierarchy with org.apache.wicket.MarkupContainer#autoAdd() (usually resolved by IComponentResolver).

        Show
        mgrigorov Martin Grigorov added a comment - In Igor's initial work the dequeued components are added as normal components, i.e. using add() (see org.apache.wicket.MarkupContainer#addDequeuedComponent). So they are not auto components. Auto components are those added to the hierarchy with org.apache.wicket.MarkupContainer#autoAdd() (usually resolved by IComponentResolver).
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit da4e4c94d899cbe0deb9a6d14bc0b1a88017a16e in wicket's branch refs/heads/improvingQueuing from Andrea Del Bene
        [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=da4e4c9 ]

        WICKET-5732 Improve component queuing and auto component

        (code review with MArtin Grigorov)

        Show
        jira-bot ASF subversion and git services added a comment - Commit da4e4c94d899cbe0deb9a6d14bc0b1a88017a16e in wicket's branch refs/heads/improvingQueuing from Andrea Del Bene [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=da4e4c9 ] WICKET-5732 Improve component queuing and auto component (code review with MArtin Grigorov)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1f04e9e43c43b40142c76a32139392154b301004 in wicket's branch refs/heads/improvingQueuing from Andrea Del Bene
        [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=1f04e9e ]

        WICKET-5732 tag 'wicket:head' can be skipped during queuing.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1f04e9e43c43b40142c76a32139392154b301004 in wicket's branch refs/heads/improvingQueuing from Andrea Del Bene [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=1f04e9e ] WICKET-5732 tag 'wicket:head' can be skipped during queuing.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1128d3c50804b8bb07f16882622f58558f4c8373 in wicket's branch refs/heads/improvingQueuing from Andrea Del Bene
        [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=1128d3c ]

        WICKET-5732 added IQueueRegion#getRegionMarkup to specify the markup of
        queue region.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1128d3c50804b8bb07f16882622f58558f4c8373 in wicket's branch refs/heads/improvingQueuing from Andrea Del Bene [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=1128d3c ] WICKET-5732 added IQueueRegion#getRegionMarkup to specify the markup of queue region.
        Hide
        bitstorm Andrea Del Bene added a comment -

        The last commit adds IQueueRegion#getRegionMarkup. This method allows to specify the markup of queue region. This makes queuing more flexible and it's also nice for components like Panel and Border which can work only on the markup that matters (the one inside <wicket:panel> or <wicket:border>)

        Show
        bitstorm Andrea Del Bene added a comment - The last commit adds IQueueRegion#getRegionMarkup. This method allows to specify the markup of queue region. This makes queuing more flexible and it's also nice for components like Panel and Border which can work only on the markup that matters (the one inside <wicket:panel> or <wicket:border>)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 0038162934fa31f79d1df6496c621b91a3957e57 in wicket's branch refs/heads/improvingQueuing from Andrea Del Bene
        [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=0038162 ]

        WICKET-5732 (code review with MArtin Grigorov)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 0038162934fa31f79d1df6496c621b91a3957e57 in wicket's branch refs/heads/improvingQueuing from Andrea Del Bene [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=0038162 ] WICKET-5732 (code review with MArtin Grigorov)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 594b511f001e5c22d6461b983b08ed505057bafa in wicket's branch refs/heads/improvingQueuing from Andrea Del Bene
        [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=594b511 ]

        WICKET-5732 Improve component queuing and auto component

        (code review with MArtin Grigorov)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 594b511f001e5c22d6461b983b08ed505057bafa in wicket's branch refs/heads/improvingQueuing from Andrea Del Bene [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=594b511 ] WICKET-5732 Improve component queuing and auto component (code review with MArtin Grigorov)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit e88b897cb488d2b22cc5b1bb2feeb9062dd88004 in wicket's branch refs/heads/improvingQueuing from Andrea Del Bene
        [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=e88b897 ]

        WICKET-5732 tag 'wicket:head' can be skipped during queuing.

        Show
        jira-bot ASF subversion and git services added a comment - Commit e88b897cb488d2b22cc5b1bb2feeb9062dd88004 in wicket's branch refs/heads/improvingQueuing from Andrea Del Bene [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=e88b897 ] WICKET-5732 tag 'wicket:head' can be skipped during queuing.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 181b9f09f27a5b9cf3def6a749da58ed7de6bb23 in wicket's branch refs/heads/improvingQueuing from Andrea Del Bene
        [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=181b9f0 ]

        WICKET-5732 added IQueueRegion#getRegionMarkup to specify the markup of
        queue region.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 181b9f09f27a5b9cf3def6a749da58ed7de6bb23 in wicket's branch refs/heads/improvingQueuing from Andrea Del Bene [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=181b9f0 ] WICKET-5732 added IQueueRegion#getRegionMarkup to specify the markup of queue region.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 5dad507aea3a48c88f3333464a281d0256dd258d in wicket's branch refs/heads/improvingQueuing from Andrea Del Bene
        [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=5dad507 ]

        WICKET-5732 (code review with MArtin Grigorov)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 5dad507aea3a48c88f3333464a281d0256dd258d in wicket's branch refs/heads/improvingQueuing from Andrea Del Bene [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=5dad507 ] WICKET-5732 (code review with MArtin Grigorov)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 8f614a52f792de1915f2484495379ba75ae1809b in wicket's branch refs/heads/improvingQueuing from Andrea Del Bene
        [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=8f614a5 ]

        WICKET-5732 Tab formatting, no functional change.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 8f614a52f792de1915f2484495379ba75ae1809b in wicket's branch refs/heads/improvingQueuing from Andrea Del Bene [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=8f614a5 ] WICKET-5732 Tab formatting, no functional change.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 9274ee2493f277dd7081991cd1558f57321443ec in wicket's branch refs/heads/master from Andrea Del Bene
        [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=9274ee2 ]

        WICKET-5732 Improve component queuing and auto component

        (code review with MArtin Grigorov)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 9274ee2493f277dd7081991cd1558f57321443ec in wicket's branch refs/heads/master from Andrea Del Bene [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=9274ee2 ] WICKET-5732 Improve component queuing and auto component (code review with MArtin Grigorov)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1771924a81514b761dacfe335f416bff879c55b4 in wicket's branch refs/heads/master from Andrea Del Bene
        [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=1771924 ]

        WICKET-5732 tag 'wicket:head' can be skipped during queuing.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1771924a81514b761dacfe335f416bff879c55b4 in wicket's branch refs/heads/master from Andrea Del Bene [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=1771924 ] WICKET-5732 tag 'wicket:head' can be skipped during queuing.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit b5d9ca5f90c78aad76fe59e90976ec138f7c2ddd in wicket's branch refs/heads/master from Andrea Del Bene
        [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=b5d9ca5 ]

        WICKET-5732 added IQueueRegion#getRegionMarkup to specify the markup of
        queue region.

        Show
        jira-bot ASF subversion and git services added a comment - Commit b5d9ca5f90c78aad76fe59e90976ec138f7c2ddd in wicket's branch refs/heads/master from Andrea Del Bene [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=b5d9ca5 ] WICKET-5732 added IQueueRegion#getRegionMarkup to specify the markup of queue region.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 7acfbff0ccb0f5b5fe58c56c8ae5b46d4b72fac1 in wicket's branch refs/heads/master from Andrea Del Bene
        [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=7acfbff ]

        WICKET-5732 (code review with MArtin Grigorov)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 7acfbff0ccb0f5b5fe58c56c8ae5b46d4b72fac1 in wicket's branch refs/heads/master from Andrea Del Bene [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=7acfbff ] WICKET-5732 (code review with MArtin Grigorov)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit b60ec64d0b50a611a9549809c9ab216f0ffa3ae3 in wicket's branch refs/heads/master from Andrea Del Bene
        [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=b60ec64 ]

        WICKET-5732 Tab formatting, no functional change.

        Show
        jira-bot ASF subversion and git services added a comment - Commit b60ec64d0b50a611a9549809c9ab216f0ffa3ae3 in wicket's branch refs/heads/master from Andrea Del Bene [ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=b60ec64 ] WICKET-5732 Tab formatting, no functional change.

          People

          • Assignee:
            bitstorm Andrea Del Bene
            Reporter:
            bitstorm Andrea Del Bene
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development