[WICKET-5520] improve reusability of DataTable and AbstractPageableView

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 6.14.0
• Fix Version/s: 7.0.0-M1, 6.15.0
• Component/s: wicket, wicket-extensions
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Dirk Germonpré
• Created: 26/Feb/14 13:03
• Updated: 05/Mar/14 13:25
• Resolved: 05/Mar/14 13:25

Description

I have a use case for the org.apache.wicket.extensions.markup.html.repeater.tree.TableTree that asks for some small modifications to the classes org.apache.wicket.extensions.markup.html.repeater.data.table.DataTable and org.apache.wicket.markup.repeater.AbstractPageableView. I would like to show a tree structure (only one level deep) in the TableTree where the number of items on a single page is not a fixed number of lines, but the number of top level nodes of the tree structure.
For this the following changes are needed:
In AbstractPageableView the method getPageCount should no longer be final.
In DataTable the constructor creates a DataGridView and assigns is to the member datagrid. The creation of the DataGridView should be refactored to a factory method (for example newDataGrid). The anonymous inner class should be replaced by a named inner class (a good name would be DefaultDataGridView). This inner class should be protected, so it can be subclassed.