[WICKET-5486] WebPageRenderer should honor RedirectPolicy.ALWAYS_REDIRECT more consistently

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 6.13.0, 7.0.0-M1
• Fix Version/s: 6.14.0, 7.0.0-M1
• Component/s: wicket
• Labels: contract unexpected
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Sven Ludwig
• Created: 23/Jan/14 14:33
• Updated: 24/Feb/14 14:46
• Resolved: 24/Feb/14 14:46

Description

In WebPageRenderer shouldPreserveClientUrl() currently has precedence over RedirectPolicy.ALWAYS_REDIRECT.

This can lead to confusion or unexpected behavior when RedirectPolicy.ALWAYS_REDIRECT is explicitely set, but for some reason shouldPreserveClientUrl() returns true and thus no redirect is performed due to the logic in WebPageRenderer.

A fix for this particular problem could be implemented in
WebPageRenderer as of Wicket 6.12.0 by changing line 211 to:

(shouldPreserveClientUrl && getRedirectPolicy() != RedirectPolicy.ALWAYS_REDIRECT)) //

Note that this problem is slightly related to WICKET-5484. Both fixes combined the line could look like this:

(shouldPreserveClientUrl && !isAjax && getRedirectPolicy() != RedirectPolicy.ALWAYS_REDIRECT)) //

Issue Links

• relates to: WICKET-3551 Using web.xml <error-page> to render error pages via Wicket yields undesired behavior in Wicket 1.5