[WICKET-5359] org.apache.wicket.util.string.StringValue#equals broken

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 6.10.0
• Fix Version/s: 6.12.0, 7.0.0-M1
• Component/s: wicket
• Assignee: Sven Meier
• Reporter: Jonas
• Created: 20/Sep/13 11:17
• Updated: 22/Sep/13 07:35
• Resolved: 20/Sep/13 19:14

Description

The #equals implementation for org.apache.wicket.util.string.StringValue is broken. The following throws an exception instead of just printing 'false':

StringValue val = StringValue.valueOf("bla", Locale.FRANCE);
StringValue val2 = StringValue.valueOf("bla", Locale.CANADA);
System.out.println(val.equals(val2));

This part of #equals
Objects.isEqual(locale, stringValue.locale)

should probably be replaced with something like
(locale == stringValue.locale || (locale != null && locale.equals(stringValue.locale))

-> Objects.isEqual is not suitable to determine equality of Locale