[WICKET-5348] JavaDoc for IColumn#getSortProperty() in misleading

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 6.10.0
• Fix Version/s: 6.11.0, 7.0.0-M1
• Labels: column columns properties property property-expression sort table
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Betlista
• Created: 12/Sep/13 13:31
• Updated: 16/Sep/13 11:54
• Resolved: 16/Sep/13 11:54

Description

JavaDoc for getSortProperty() in org.apache.wicket.extensions.markup.html.repeater.data.table.IColumn<T, S> interface states:

"Returns the name of the property that this header sorts. If null is returned the header will be unsortable."

According to this JavaDoc I'd expect that it should be String.

I assume that someone would like to use something other than String. But I think that at least for PropertyColumn it has to be bound to String, so change the:

public class PropertyColumn<T, S> extends AbstractColumn<T, S> implements IExportableColumn<T, S, Object>

to:

public class PropertyColumn<T> extends AbstractColumn<T, String> implements IExportableColumn<T, String, Object>

because referenced PropertyModel is not parameterized with S.

I also suggest to add PropertySortParam that extends SortParam<String> to framework.

And also IPropertyColumn<T> interface that extends IColumn<T, String>.

@param <T> for IColumn<T, S> is not described too.