Wicket
  1. Wicket
  2. WICKET-5273

Tabindex overwritten in modal window for IE - Works in FF, Chrome

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 6.9.1
    • Fix Version/s: 6.10.0, 7.0.0-M1
    • Component/s: None
    • Labels:
      None

      Description

      Attribute tabindex gets overwritten in ModalDialog, when using IE 8,9,10.. It works fine in FF, Chrome.
      This breaks chances of creating accessability by using tab.

      See attachment for testproject, which works in ff,chrome, fails in ie 8,9,10.
      1) Open modallink (lightbox)
      2) use tabbutton - in ff, chrome you'll tab between closebutton and content, in ie this fails cause tabindex gets overwritten by -1.

      I suspect it's this codepart in modal.js that does it.

      if (Wicket.Browser.isIE()) {
      this.disabledTabsRevertList = [];
      for (var j = 0; j < this.tabbableTags.length; j++) {
      var tagElements = doc.getElementsByTagName(this.tabbableTags[j]);
      for (var k = 0 ; k < tagElements.length; k++) {
      // if this is not an iframe window and the element is child of window content,
      // don't disable tab on it
      if (win.isIframe() === true || this.isParent(tagElements[k], win.content) === false)

      { var element = tagElements[k]; element.hiddenTabIndex = element.tabIndex; element.tabIndex="-1"; this.disabledTabsRevertList.push(element); }

      }
      }
      }

        Activity

        Hide
        Martin Grigorov added a comment -

        Modified the check which tabbableTags to disable by allowing tabIndex in all elements in the Modal Window, not just in the 'content' part. That means now all tabbable elements in the 'caption' won't be disabled.

        Show
        Martin Grigorov added a comment - Modified the check which tabbableTags to disable by allowing tabIndex in all elements in the Modal Window, not just in the 'content' part. That means now all tabbable elements in the 'caption' won't be disabled.

          People

          • Assignee:
            Martin Grigorov
            Reporter:
            J
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development