Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-5251

Minified name resolves incorrectly if default resource reference is used

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 6.8.0
    • Fix Version/s: 6.10.0, 7.0.0-M1
    • Component/s: wicket
    • Labels:
      None

      Description

      In PackageResourceReference.

      When a default reference to a minified resource is used (i.e. the resource wasn't mounted) the resource reference name includes '.min'.

      When trying to resolve the minified name, another '.min' is appended, resulting in the minified name resolving to 'html5.min.min.js'.

      As a result, the PackageResourceReference concludes that the resource was not minified, and adds compression.

        Activity

        Hide
        cedricgatay Cedric Gatay added a comment -

        I'm taking this one.

        Show
        cedricgatay Cedric Gatay added a comment - I'm taking this one.
        Hide
        cedricgatay Cedric Gatay added a comment -

        You can find a fix for already minified resources by name detection at the following URL : https://github.com/CedricGatay/wicket/compare/WICKET-5251?expand=1

        Show
        cedricgatay Cedric Gatay added a comment - You can find a fix for already minified resources by name detection at the following URL : https://github.com/CedricGatay/wicket/compare/WICKET-5251?expand=1
        Hide
        mgrigorov Martin Grigorov added a comment -

        Thanks, Cedric!

        Show
        mgrigorov Martin Grigorov added a comment - Thanks, Cedric!

          People

          • Assignee:
            mgrigorov Martin Grigorov
            Reporter:
            johannes.odland@gmail.com Johannes Odland
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development