[WICKET-5237] Wicket generates invalid HTML by expanding col tags

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 6.8.0
• Fix Version/s: 6.9.0, 7.0.0-M1
• Labels: html

Environment

Ubuntu 12.10, 3.5.0-32-generic #53-Ubuntu SMP Wed May 29 20:23:04 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux
java version "1.7.0_21"
Java(TM) SE Runtime Environment (build 1.7.0_21-b11)
Java HotSpot(TM) 64-Bit Server VM (build 23.21-b01, mixed mode)

• Assignee: Martin Tzvetanov Grigorov
• Reporter: Konrad Mohrfeldt
• Created: 17/Jun/13 10:25
• Updated: 19/Jun/13 09:27
• Resolved: 19/Jun/13 09:27

Description

hi,

I just noticed that wicket expands col tags, even though the (x)html specifications forbids it.

take this markup as an example:

<table>
<colgroup>
<col width="20%" />
<col width="80%" />
</colgroup>
<tbody>
<tr>
<td>I take a fifth of the available space</td>
<td>I take four fifth of the available space</td>
</tr>
</tbody>
</table>

Instead of return this as-is, it get's converted to:

<table>
<colgroup>
<col width="20%"></col>
<col width="80%"></col>
</colgroup>
<tbody>
<tr>
<td>I take a fifth of the available space</td>
<td>I take four fifth of the available space</td>
</tr>
</tbody>
</table>

But the specifications mention that col tags must not have end tags. This may be related to WICKET-2765, as this seems to be the point when col was added to the OpenCloseTagExpander class. Note that it is ok to have a non closing col tag in html (self-closing in xhtml). It's all about generating a separated end tag.

This happens in wicket 6.8, but I guess it's relevant to all versions down to wicket 1.4.

Specs for reference:

http://www.w3.org/TR/1999/REC-html401-19991224/struct/tables.html#edef-COL
http://www.w3.org/TR/html-markup/col.html

Kind regards,

Konrad