Wicket
  1. Wicket
  2. WICKET-5127

Dont use sun-internal packages to allow easy jdk7 compilation

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 6.7.0
    • Fix Version/s: 6.7.0
    • Component/s: wicket
    • Labels:
      None

      Description

      Hi Devs,

      I´m not able to compile the wicket-sources on my notebook, no matter what I try.

      I try to compile with JDK7, that always worked but now some Problems seem to arise.

      In the new JsonSequenceStringer-Class we make use of the sun internal:

      com.sun.istack.internal.Nullable;

      I dont think its a very good idea to use sun internal classes here, even if jdk6 is the target of the current source base, we should allow jdk7 to compile it. Thats not possible at the moment.

      The attached patch just removes this usage. We wont lose much here.
      Or am I missing something important?

        Activity

        Martin Dilger created issue -
        Martin Dilger made changes -
        Field Original Value New Value
        Attachment 0001-Dont-use-sun-internal-packages-as-this-breaks-compil.patch [ 12576351 ]
        Igor Vaynberg made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Igor Vaynberg [ ivaynberg ]
        Fix Version/s 6.7.0 [ 12323964 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Igor Vaynberg
            Reporter:
            Martin Dilger
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development