Wicket
  1. Wicket
  2. WICKET-5088

The Bootstrap class does not provide a handle for the CSSResourceReferences.

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 6.6.0
    • Fix Version/s: 6.7.0
    • Component/s: None
    • Labels:
      None

      Description

      The Bootstrap class provides JavaScriptResourceReference via the plain() and responsive() methods.

      It should also provide access to bootstrapCss and bootstrapResponsiveCss to enable the applications to use CSS bundles.

        Activity

        Hide
        Martin Grigorov added a comment -

        Now the CSS resource references are 'public static final'.
        See WICKET-5089 for an explanation how to add a reference to a bundle without having access to the instance.

        Show
        Martin Grigorov added a comment - Now the CSS resource references are 'public static final'. See WICKET-5089 for an explanation how to add a reference to a bundle without having access to the instance.
        Hide
        Sylvain Vieujot added a comment -

        Thank you.
        However, adding Bootstratp's CSS to a bundle seems to fail as the bootstrap icons are broken.
        Probably because the path is relative to Bootstrap's CSS, not to the resource bundle's css.

        Any idea on how to solve this ?

        Show
        Sylvain Vieujot added a comment - Thank you. However, adding Bootstratp's CSS to a bundle seems to fail as the bootstrap icons are broken. Probably because the path is relative to Bootstrap's CSS, not to the resource bundle's css. Any idea on how to solve this ?
        Hide
        Martin Grigorov added a comment -

        This is valid for any .css with url(some.image) with relative path.
        If you change the url of the .css then the image cannot be found anymore.

        I'd recommend you to use font icons like the ones from http://fontello.com.
        Twitter Bootstrap 3 will also use font icons: https://github.com/twitter/bootstrap/pull/6342, Font icons! Converted to Glyphicons v1.7 @font-face, dropping the old PNGs.

        Show
        Martin Grigorov added a comment - This is valid for any .css with url(some.image) with relative path. If you change the url of the .css then the image cannot be found anymore. I'd recommend you to use font icons like the ones from http://fontello.com . Twitter Bootstrap 3 will also use font icons: https://github.com/twitter/bootstrap/pull/6342 , Font icons! Converted to Glyphicons v1.7 @font-face, dropping the old PNGs.

          People

          • Assignee:
            Martin Grigorov
            Reporter:
            Sylvain Vieujot
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development