Wicket
  1. Wicket
  2. WICKET-5074

Improvement for MockHttpServletRequest and FormTester to support 'multiple' input type of fileUpload

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 6.6.0
    • Fix Version/s: 6.7.0
    • Component/s: wicket
    • Labels:
      None

      Description

      Right now MockHttpServletRequest keeps a Map<String, UploadedFile> uploadedFiles to simulate the uploads, but that only covers multiple FileUploadFields in the Page(each holding a single upload file).
      When doing MockHttpServletRequest.addFile(...), it does not add the file to a list, but rather replaces the last one:
      uploadedFiles.put(fieldName, uf);

      However with the HTML5 type of input type multiple="multiple", FileUploadField.getFileUploads() returns list of uploaded files, so I guess that MockHttpServletRequest should honor this and keep the files into Map<String, List<UploadedFile>>.

        Activity

        Hide
        Martin Grigorov added a comment -

        Improved.
        Please test it before Friday (15.03.2013) if you can. Wicket 6.7.0 will be cut then.

        Show
        Martin Grigorov added a comment - Improved. Please test it before Friday (15.03.2013) if you can. Wicket 6.7.0 will be cut then.
        Hide
        Serban Balamaci added a comment -

        Hi Martin, woks ok on my usecase at least.
        Thanks.

        Show
        Serban Balamaci added a comment - Hi Martin, woks ok on my usecase at least. Thanks.

          People

          • Assignee:
            Martin Grigorov
            Reporter:
            Serban Balamaci
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development