Wicket
  1. Wicket
  2. WICKET-5057

FilteringHeaderResponse requires a usage of FilteringHeaderResponse.IHeaderResponseFilter for no reason when FilteredHeaderItem is used

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 6.6.0
    • Fix Version/s: 6.7.0
    • Component/s: wicket
    • Labels:
      None

      Description

      org.apache.wicket.markup.head.filter.FilteringHeaderResponse#render(HeaderItem) doesn't need a filter when a FilteredHeaderItem is processed. But later org.apache.wicket.markup.head.filter.FilteringHeaderResponse#render(HeaderItem item, String filterName) requires such filter.

      I think we can create a bundle (List<HeaderItem>) on the fly in this case for the first FHI.

      Otherwise right now the developer has to use:

      AbstractHeaderResponseFilter dummyFilter = new AbstractHeaderResponseFilter(coreFilterName) {
      @Override
      protected boolean acceptsWrapped(HeaderItem item)

      { return false; }

      };
      filters.add(dummyFilter);

      in his HeaderResponseDecorator.

        Activity

        Martin Grigorov made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Martin Grigorov made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Martin Grigorov [ mgrigorov ]
        Resolution Fixed [ 1 ]
        Martin Grigorov made changes -
        Field Original Value New Value
        Fix Version/s 6.7.0 [ 12323964 ]
        Martin Grigorov created issue -

          People

          • Assignee:
            Martin Grigorov
            Reporter:
            Martin Grigorov
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development