[WICKET-5057] FilteringHeaderResponse requires a usage of FilteringHeaderResponse.IHeaderResponseFilter for no reason when FilteredHeaderItem is used

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 6.6.0
• Fix Version/s: 6.7.0
• Component/s: wicket
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Martin Tzvetanov Grigorov
• Created: 26/Feb/13 14:00
• Updated: 27/Feb/13 13:35
• Resolved: 27/Feb/13 13:35

Description

org.apache.wicket.markup.head.filter.FilteringHeaderResponse#render(HeaderItem) doesn't need a filter when a FilteredHeaderItem is processed. But later org.apache.wicket.markup.head.filter.FilteringHeaderResponse#render(HeaderItem item, String filterName) requires such filter.

I think we can create a bundle (List<HeaderItem>) on the fly in this case for the first FHI.

Otherwise right now the developer has to use:

AbstractHeaderResponseFilter dummyFilter = new AbstractHeaderResponseFilter(coreFilterName) {
@Override
protected boolean acceptsWrapped(HeaderItem item)

{ return false; }

};
filters.add(dummyFilter);

in his HeaderResponseDecorator.