[WICKET-5054] Possible bug in org.apache.wicket.util.lang.Packages when building path with repeating names

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 6.6.0, 1.5.10
• Fix Version/s: 6.7.0, 1.5.11
• Component/s: wicket
• Assignee: Sven Meier
• Reporter: Christophe Levesque
• Created: 22/Feb/13 20:33
• Updated: 04/Nov/13 11:40
• Resolved: 24/Feb/13 09:53

Description

When trying to build the absolute path from package "com.foo.bar" with relative path "baz/foo/qux" in method org.apache.wicket.util.lang.Packages.absolutePath(String, String) the block:

				else if (absolutePath.size() <= i || absolutePath.get(i).equals(folder) == false)
				{
					// Add to stack
					absolutePath.add(folder);
				}

doesn't run for the "foo" part of the relative path because absolutePath.get(1) == foo from the package == foo from the relative path.

So the resulting absolute path is "com/foo/bar/baz/qux" rather than the expected "com/foo/bar/baz/foo/qux".

Seems like the "else if" should just be a "else".