Wicket
  1. Wicket
  2. WICKET-5006

Improve null display value in AbstractSingleSelectChoice

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 6.5.0
    • Fix Version/s: 6.6.0
    • Component/s: wicket
    • Labels:
      None

      Description

      AbstractSingleSelectChoice makes it hard to customize the display values for null because it's hard coded to look it up by property keys. This is done in getDefaultChoice and it's not possible to change the behavior without overriding the whole method.

      I extracted getNullValidDisplayValue and getNullKeyDisplayValue which are then called in getDefaultChoice and default to the current behavior. Now subclasses can change these values easily.

      1. WICKET-5006.patch
        3 kB
        Christoph Leiter

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        3d 1h 15m 1 Martin Grigorov 28/Jan/13 10:33
        Martin Grigorov made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Martin Grigorov [ mgrigorov ]
        Fix Version/s 6.6.0 [ 12323963 ]
        Resolution Fixed [ 1 ]
        Christoph Leiter made changes -
        Field Original Value New Value
        Attachment WICKET-5006.patch [ 12566490 ]
        Christoph Leiter created issue -

          People

          • Assignee:
            Martin Grigorov
            Reporter:
            Christoph Leiter
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development